Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new character sheet - Alternate version #450

Merged
merged 19 commits into from
Sep 29, 2020
Merged

Adds new character sheet - Alternate version #450

merged 19 commits into from
Sep 29, 2020

Conversation

Jessomadic
Copy link
Member

@Jessomadic Jessomadic commented Sep 19, 2020

Description: Adds new character sheet

Alternate version

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@datdamnzotz
Copy link

datdamnzotz commented Sep 21, 2020

fillable-char-sheetstyle-2 are not populating spells.
image
Missing
image
Missing
image

@datdamnzotz
Copy link

datdamnzotz commented Sep 21, 2020

Features and traits in fillable-char-sheetstyle-3 spells are not populating.
image

Same with current hitpoints
image

@Jessomadic
Copy link
Member Author

Jessomadic commented Sep 21, 2020

That's strange. Is that happening on all spell sheet numbers or just one? For the style 3 features and the style 2 spells. I have to head into work for a few hours but I'll be sure to look over everything again once I am done

@datdamnzotz
Copy link

That's strange. Is that happening on all spell sheet numbers or just one? For the style 3 features and the style 2 spells. I have to head into work for a few hours but I'll be sure to look over everything again once I am done

That was a level 20 wizard - so its pulling the 6th sheet. But need to check them all to make sure the fields are correct.

@Jessomadic
Copy link
Member Author

That's strange. Is that happening on all spell sheet numbers or just one? For the style 3 features and the style 2 spells. I have to head into work for a few hours but I'll be sure to look over everything again once I am done

That was a level 20 wizard - so its pulling the 6th sheet. But need to check them all to make sure the fields are correct.

I will definitely take a look. I made one that was a level 20 wizard and a level 20 warlock to make sure everything worked and it did but I might have missed something.

@Jessomadic
Copy link
Member Author

Jessomadic commented Sep 21, 2020

image The Hitpoint field is 100% correct on the 3rd Style sheet. It might be something on your end? @datdamnzotz

@Jessomadic
Copy link
Member Author

Likewise the Spellsheets on style 2 is correct. However more fields broke for that second page and will be fixed
image

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself area/pdf enhancement New feature or request labels Sep 28, 2020
@datdamnzotz datdamnzotz added this to the 2.5.0.17 milestone Sep 28, 2020
@datdamnzotz datdamnzotz linked an issue Sep 28, 2020 that may be closed by this pull request
datdamnzotz and others added 2 commits September 29, 2020 10:48
Removed Selection 3 (Icewind Dale) temp
@datdamnzotz datdamnzotz changed the title Adds new character sheets Adds new character sheet - Alternate version Sep 29, 2020
Copy link

@datdamnzotz datdamnzotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 smoke tests look good - release to the wild

@datdamnzotz datdamnzotz merged commit e775768 into Orcpub:develop Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application Task related to orcpub application itself area/pdf enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds new character sheet - Alternate version
2 participants