Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page overflow due to roll tooltips in character page #420

Merged
merged 6 commits into from
Jul 16, 2020

Conversation

Pireax
Copy link

@Pireax Pireax commented Jul 11, 2020

Description:

The tooltips for the roll buttons take up space outside of the page even when not visible, this makes it such that the page is larger than the viewport and you can scroll horizontally, but there is nothing there. A function was created for all roll buttons and the code was refactored to use this function, tooltips are disabled for the roll button if on mobile (you can't hover over an item with touch input anyways).

image

Fixes: #421

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself bug Something isn't working labels Jul 11, 2020
@datdamnzotz datdamnzotz added this to the 2.5.0.17 milestone Jul 11, 2020
datdamnzotz
datdamnzotz previously approved these changes Jul 11, 2020
Copy link

@datdamnzotz datdamnzotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pireax
Copy link
Author

Pireax commented Jul 11, 2020

Still found some issues, please wait with merging

@datdamnzotz
Copy link

NP. I won't release it till monday some time anyways, Weekends in the busy DND time : ]

datdamnzotz
datdamnzotz previously approved these changes Jul 16, 2020
Copy link

@datdamnzotz datdamnzotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@datdamnzotz datdamnzotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@datdamnzotz datdamnzotz merged commit 14ed532 into Orcpub:develop Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page overflow due to roll tooltips in character page
2 participants