-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix page overflow due to roll tooltips in character page #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Still found some issues, please wait with merging |
NP. I won't release it till monday some time anyways, Weekends in the busy DND time : ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description:
The tooltips for the roll buttons take up space outside of the page even when not visible, this makes it such that the page is larger than the viewport and you can scroll horizontally, but there is nothing there. A function was created for all roll buttons and the code was refactored to use this function, tooltips are disabled for the roll button if on mobile (you can't hover over an item with touch input anyways).
Fixes: #421
Checklist: