Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account menu not working correctly on some mobile browsers #417

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Fix account menu not working correctly on some mobile browsers #417

merged 1 commit into from
Jul 16, 2020

Conversation

Pireax
Copy link

@Pireax Pireax commented Jul 11, 2020

Description:

Related issue (if applicable): fixes #416

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@Pireax Pireax changed the title Fix #416 Fix account menu not working correctly on some mobile browsers Jul 11, 2020
@codeGlaze
Copy link

Holy crap!

codeGlaze
codeGlaze approved these changes Jul 11, 2020
View reviewed changes
Copy link

@codeGlaze codeGlaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you :)

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself bug Something isn't working labels Jul 11, 2020
@datdamnzotz datdamnzotz added this to the 2.5.0.17 milestone Jul 11, 2020
@datdamnzotz datdamnzotz merged commit 1f70604 into Orcpub:develop Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeGlaze codeGlaze codeGlaze approved these changes

Assignees

@Pireax Pireax

Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
None yet
Milestone
2.5.0.17
Development

Successfully merging this pull request may close these issues.

Account menu does not work on mobile
3 participants
@Pireax @codeGlaze @datdamnzotz