Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracers of Archery do not apply damage bonus #514

Closed
codeGlaze opened this issue Feb 28, 2021 · 0 comments · Fixed by #515
Closed

Bracers of Archery do not apply damage bonus #514

codeGlaze opened this issue Feb 28, 2021 · 0 comments · Fixed by #515
Assignees
Labels
area/application Task related to orcpub application itself bug Something isn't working
Milestone

Comments

@codeGlaze
Copy link

Describe the bug
Bracers of Archery should apply a +2 bonus to short/longbow damage. As well as grant proficiency in both weapons.
Currently none of that applies.

To Reproduce

Steps to reproduce the behavior:
Equip Bracers of Archery on any character, preferably one without short/longbow proficiencies.
Notice missing bonus and missing proficiencies.

@codeGlaze codeGlaze added the bug Something isn't working label Feb 28, 2021
@codeGlaze codeGlaze self-assigned this Feb 28, 2021
codeGlaze added a commit to codeGlaze/orcpub that referenced this issue Feb 28, 2021
* Fixed Dueling style not applying +2 bonus to one handed melee weapons.
    + Properly checks for weapons in only one hand
    + Properly only applies to non-two handed melee weapons

* Commented out melee- and ranged- specific damage bonus methods. Weird front end issues occurred when `apply` was... applied to those maps plus the map for the generic `damage-bonus-fns`
    * Properly utilizing the passed functions and conditions should eliminate the need for those other two methods.

* Fixed Bracers of Archery applying attack bonus instead of damage bonus
    * Added new method `weapon-damage-bonus-mod` which duplicates almost all the code from `weapon-attack-bonus-mod`. Combining them may be worthwhile, using a third parameter to set which bonus we want, or even both.
@datdamnzotz datdamnzotz added the area/application Task related to orcpub application itself label Mar 20, 2021
@datdamnzotz datdamnzotz added this to the 2.5.0.21 milestone Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants