Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UseCdn Picker to Setup Page #7707

Closed
wants to merge 12 commits into from
Closed

Add UseCdn Picker to Setup Page #7707

wants to merge 12 commits into from

Conversation

hyzx86
Copy link
Contributor

@hyzx86 hyzx86 commented Nov 21, 2020

@Skrypt
Copy link
Contributor

Skrypt commented Nov 21, 2020

We have a discussion next week about this. Your PR doesn't cover all scenarios. For example, here it will maybe work in the setup page. But it should be set before getting to the setup page. And even if the setup works afterward if you go to /admin the CDN issue will still remain.

@hyzx86
Copy link
Contributor Author

hyzx86 commented Nov 21, 2020

This problem has been going on for a year,
let's fix it first.
There are 1.4 billion people who don't have access to these CDN resources. A large number of new entrants have struggled with this problem. If there are any other problems, let's submit a new PR to solve them.

Thanks!

@Skrypt Skrypt mentioned this pull request Nov 23, 2020
@Skrypt
Copy link
Contributor

Skrypt commented Nov 23, 2020

Duplicate PR see : #7599

@sebastienros
Copy link
Member

Closing since there is another PR with the same goal. And my preference is to just have local assets by default.

@hyzx86
Copy link
Contributor Author

hyzx86 commented Jan 15, 2021

Hi @sebastienros , Has the problem not been solved yet?
I found that the latest version still requires manual code to avoid loading resources from the CDN.

@hyzx86 hyzx86 deleted the dev branch April 26, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants