Update of open id recipes #7646
Conversation
- not using viewmode - recipe can be run multiple times Update of openID scope Step - not using viewmode - recipe can be run multiple times ScopeController Update of openID scope page - Give user feedback when spaces are added in the name
src/OrchardCore.Modules/OrchardCore.OpenId/Controllers/ScopeController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.OpenId/Recipes/OpenIdApplicationStep.cs
Show resolved
Hide resolved
|
@kevinchalet Can you please review this PR? |
|
|
||
| var descriptor = new OpenIdApplicationDescriptor | ||
| var descriptor = new OpenIdApplicationDescriptor(); | ||
| if (application!=null) |
|
|
||
| descriptor.Permissions.Remove(OpenIddictConstants.Permissions.GrantTypes.ClientCredentials); |
There was a problem hiding this comment.
It would have been better to use the same if/else logic as the one used in the controllers to make things more consistent and avoid discrepancies between recipes and controllers, but it shouldn't be blocking to merge this PR,
There was a problem hiding this comment.
Is it better to create an OpenIdApplicationService with an Create and Edit function with an ApplicationModel?
Then use this service in the recipe and the controller?
There was a problem hiding this comment.
It's an option, but the problem is that the step and view models are 2 different CLR classes, so we'd to either merge the classes or introduce some interfaces. Dunno if it's worth it or not.
If anything, it would be better to put that in IOpenIdApplicationManager.
| if (model.AllowAuthorizationCodeFlow) | ||
| { | ||
| descriptor.Permissions.Add(OpenIddictConstants.Permissions.GrantTypes.AuthorizationCode); | ||
| } | ||
| if (model.AllowClientCredentialsFlow) | ||
| { | ||
| descriptor.Permissions.Add(OpenIddictConstants.Permissions.GrantTypes.ClientCredentials); | ||
|
|
||
| if (model.Roles!= null && model.Roles.Any()) |
- not using viewmode - recipe can be run multiple times Update of openID scope Step - not using viewmode - recipe can be run multiple times ScopeController Update of openID scope page - Give user feedback when spaces are added in the name
…no/OrchardCore into feature/6364_openIdRecepes
|
I think you had a bad merge here as there are over 1200 file changes. Can you reset the pr please? |
|
The #6364 issue has since been fixed by other PRs. Thank you for your contribution, but I'm now closing this. |
Update of openID application Step
Update of openID scope Step
Update of openID scope page
Fixes #6364