-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sitemaps module revisited #4450
Conversation
…ted with sitemap provider in anyway
…p related settings
…s and sitemap treesummaries. and started adding rootpath to sitemap sets
…. removed dependance on MenuItem from SitemapNode and can now call IDisplayManager<SitemapNode>. OC is brilliant!
… future support for creating an images sitemap
…er take result - that should be returned, but builders for recursion, and implemented optional providelastmodified date for nodes
…low limits of 50000
…ng sitemap size. Included contained parts in ContentTypesSitemapNodeDriver. Not totally happy with that solution. Seems to restrictive
…ns, convert tree to columns as well.
…route services out of sitemapsetservice.
…s can't be contained, but sitemaps can, but can't contain childnodes)
…k not overreferencing unecesary modules
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Contents/Startup.cs
# Conflicts: # OrchardCore.sln
Pending demo really. There’s a couple of things to review on the ui, but no showstoppers I hope |
Reviewed after update to core 3.1. Ready |
Can't wait to try this module out! Nice work! |
Ok I'm testing this on my website and even after adding a BaseUrl in the site settings the sitemap.xml elements doesn't contain it. Ok resolved the issue by clearing the sm-cache folder and regenerating the sitemap cached files. So this works fine. Ok so one thing is missing and it's a button to empty this sitemap cache per sitemap. |
For info publishing clears the cache as well
Yes, agreed, was on my list to add :) |
Fixes #3219
Moving the sitemaps module I started on #3229 over to here, as that git account has ghosted.
I've simplified this quite a lot, and am still expecting a bit more to do with it.
@jtkech If you have any time to have a look at how I've done the routing that would be great.
I've struggled to get it running through normal middleware, as the link generator won't build a pretty link unless the mvc pipeline has been built, so I've ended up sticking with a routing constraint, so it can get to a controller, where the UrlHelper will build good routes, without having to depend on the AutoroutePart, or AutorouteEntries - meaning it should be url's for items that aren't using Autoroute as well.
There's a few other strange things I've done, like putting the SitemapPart in an abstractions module.
Open to all suggestions :)