-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab support for admin / content edit #3626
Conversation
…) tab divs for admin tabs. (no javascript yet etc)
We need a way to expose metadata in a file to describe new localized entries. |
I think this is quite similar to the dynamic content localization described in #3607. My idea is to define a provider, that return all localizable strings from the specific feature. We can call these providers at runtime and export all strings to a POT file. User provides translated PO files and either deploy them alongside other PO files or we might add another
There might be several providers e.g.
|
Thanks for this @deanmarcussen |
@sebastienros Not particularly responsive! Bootstrap I've made them They could go into a collapse if there were a lot of them (> 5) perhaps Note - should do something with the |
# Conflicts: # src/OrchardCore.Themes/TheAdmin/wwwroot/Styles/TheAdmin.css # src/OrchardCore.Themes/TheAdmin/wwwroot/Styles/TheAdmin.min.css
@sebastienros What would you like me to do with this, regarding localization? Remove references to |
Don't localize any dynamic value until we have solved it. |
This adds support for Tabs in the Admin - adapted from O1
Covers issues from SEO module #3214 , and also wanted for Sitemaps #3229, and original issue #1822
Validation remains outside the tabs
I also tweaked the
CodeMirror
sass to fix #3625I included the content item id in the tab-pane id, to allow for multiple tab-groups to be rendered if this gets reused to move anything else into tabs (personally I'd love to see the different content localizations in tabs so you could flick between them when editing, but that's a whole nother piece of work!)
Styling is an extension of bootstrap tabs, so works with rtl.
In the example image above I've just used a
placement.json
file in the admin theme to move theTitlePart
to create the second tab. As per O1 if there are no tabs the editor does not display the tab dialog, or wrap the content in a border.Test
placement.json
fileNote : Not sure about the use of the localized string checks that I bought over from O1. Might make more sense to just wrap
@tabname
in aT(@tabName)
- open to suggestions :)