Admin Theme add min asset back #17530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is an example on how this could be done. Though, I'd rather have .map files because serving unminified assets on prod is unecessary. Also, if you want to debug your assets you don't want to serve all unminified assets at the same time on dev. With the new Asset Manager tool you want to simply do `yarn watch -n asset-name` so that this asset gets recompiled in "development" mode as unminified/unoptimized. Else, if you want to debug on your Production server then, you should have a .map file instead of serving every assets as unminified/unoptimized. Here, the only risky thing that could happen is that the file did not get compiled yet in the wwwroot folder. You need at least to set the "min" action after the "parcel" action in your Assets.json file to start minifying this file. I don't want to start a second Parcel process to do this, this is why I created the "min" action. Though, it adds unecessary compilation time that should rather be spent on making the .map files story work.
|
Nevermind this won't work. It creates already a min asset file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example on how this could be done.
Though, I'd rather have .map files because serving unminified assets on prod is unecessary. Also, if you want to debug your assets you don't want to serve all unminified assets at the same time on dev. With the new Asset Manager tool you want to simply do
yarn watch -n asset-nameso that this asset gets recompiled in "development" mode as unminified/unoptimized. Else, if you want to debug on your Production server then, you should have a .map file instead of serving every assets as unminified/unoptimized.Here, the only risky thing that could happen is that the file did not get compiled yet in the wwwroot folder. You need at least to set the "min" action after the "parcel" action in your Assets.json file to start minifying this file. I don't want to start a second Parcel process to do this, this is why I created the "min" action. Though, it adds unecessary compilation time that should rather be spent on making the .map files story work.