Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Search module's hidden dependency on Contents #17479

Merged
merged 3 commits into from
Feb 12, 2025
+13 −5
Merged

Fix the Search module's hidden dependency on Contents #17479

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a1cba9
Fix dependency on contents
MikeAlhayek Feb 11, 2025
2992e4c
fix build
MikeAlhayek Feb 11, 2025
ae083e4
move the part and the driver
MikeAlhayek Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/OrchardCore.Modules/OrchardCore.Search/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ public override void ConfigureServices(IServiceCollection services)

services.AddContentPart<SearchFormPart>()
.UseDisplayDriver<SearchFormPartDisplayDriver>();

services.AddDataMigration<SearchMigrations>();
}

public override void Configure(IApplicationBuilder app, IEndpointRouteBuilder routes, IServiceProvider serviceProvider)
Expand All @@ -50,6 +48,15 @@ public override void Configure(IApplicationBuilder app, IEndpointRouteBuilder ro
}
}

[RequireFeatures("OrchardCore.Contents")]
public sealed class ContentsStartup : StartupBase
{
public override void ConfigureServices(IServiceCollection services)
{
services.AddDataMigration<SearchMigrations>();
}
}

[RequireFeatures("OrchardCore.Deployment")]
public sealed class DeploymentStartup : StartupBase
{
Expand Down