Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping Microsoft.Identity* packages in Renovate too (Lombiq Technologies: OCORE-212) #17187

Merged
merged 12 commits into from
Dec 10, 2024

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Dec 9, 2024

No description provided.

@Piedone Piedone changed the title Grouping Microsoft.Identity* packages in Renovate too Grouping Microsoft.Identity* packages in Renovate too (Lombiq Technologies: OCORE-212) Dec 9, 2024
@kevinchalet
Copy link
Member

Looks good.

Note: the OpenIddict and Microsoft.AspNetCore.Authentication.OpenIdConnect packages also depend on IdentityModel, so maybe they should be part of a larger group if we want to cover everything?

@Piedone Piedone requested a review from kevinchalet December 9, 2024 17:27
@Piedone
Copy link
Member Author

Piedone commented Dec 9, 2024

Good point. How about now?

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@Piedone Piedone merged commit 1c890da into OrchardCMS:main Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants