Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the new AddResourceConfiguration to the Abstractions project #17107

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@MikeAlhayek MikeAlhayek requested a review from Piedone December 2, 2024 20:15
@Piedone
Copy link
Member

Piedone commented Dec 2, 2024

I contemplated putting this there (together with the .Core project) but it's not actually an abstraction: it's neither an interface nor a fundamental concrete type, but a concrete implementation that needs to be like this only because ResourceManager uses ResourceManagementOptions like this. Solely from ResourceManagementOptions it doesn't follow that we should have this registration (and still, it's not an abstraction).

@MikeAlhayek
Copy link
Member Author

I don't see an issue with placing it in the abstraction. The ResourceManagement is part of the abstraction, so to implement a new resource management, you'll need the abstractions only. So it does not make sense to include other project just to use that extension. I think it's fair to put it in the abstraction project so people don't need to include yet another library. If we move it to core, they would have to switch from using Abstractions to Core.

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, just be sure to revert the csproj changes under https://github.com/OrchardCMS/OrchardCore/pull/17095/files and feel free to merge.

MikeAlhayek and others added 3 commits December 3, 2024 07:43
…rviceCollectionExtensions.cs

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
@MikeAlhayek MikeAlhayek enabled auto-merge (squash) December 3, 2024 15:49
@MikeAlhayek MikeAlhayek merged commit 69762e2 into main Dec 3, 2024
7 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/ResourceManagementOptions branch December 3, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants