Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SQL document queries don't work on older existing tenants (Lombiq Technologies: OCORE-195) #16581

Merged
merged 23 commits into from
Aug 20, 2024
Merged

Fix SQL document queries don't work on older existing tenants (Lombiq Technologies: OCORE-195) #16581

merged 23 commits into from
Aug 20, 2024

Conversation

sarahelsaig
Copy link
Contributor

Fixes #16580

@sarahelsaig
Copy link
Contributor Author

Bug fix is here. I also did some code organization and additional logging too.

@sarahelsaig sarahelsaig requested a review from gvkries August 19, 2024 12:15
gvkries
gvkries approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@gvkries gvkries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sarahelsaig

@MikeAlhayek
Copy link
Member

@sarahelsaig I did not see this PR until after I submitted #16582 isn't my approach simpler?

@gvkries gvkries mentioned this pull request Aug 19, 2024
Closed
@gvkries
Copy link
Contributor

gvkries commented Aug 19, 2024

I think the additional logging makes sense, also she made the code simpler to understand in general.

@sarahelsaig @MikeAlhayek
Update src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlQuerySource.cs
ba40dca 
Co-authored-by: Mike Alhayek <mike@crestapps.com>
sarahelsaig and others added 2 commits August 19, 2024 21:25
@sarahelsaig @hishamco
Update src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlQuerySource.cs
25fbf7b 
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
@sarahelsaig @hishamco
Update src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlQuerySource.cs
0d3870f 
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
@sarahelsaig @hishamco
Update src/OrchardCore.Modules/OrchardCore.Queries/Sql/SqlQuerySource.cs
df627b8 
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
@MikeAlhayek MikeAlhayek merged commit 3fe9612 into OrchardCMS:main Aug 20, 2024
5 checks passed
This was referenced Sep 1, 2024
Open
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamco hishamco hishamco approved these changes

@MikeAlhayek MikeAlhayek Awaiting requested review from MikeAlhayek

@gvkries gvkries Awaiting requested review from gvkries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL document queries don't work on older existing tenants
4 participants
@sarahelsaig @MikeAlhayek @gvkries @hishamco