-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable implicit usings #16574
Enable implicit usings #16574
Conversation
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Workflows/WorkflowPruning/Drivers/WorkflowPruningDisplayDriver.cs # src/OrchardCore.Modules/OrchardCore.Workflows/WorkflowPruning/Services/WorkflowPruningBackgroundTask.cs # src/OrchardCore.Modules/OrchardCore.Workflows/WorkflowPruning/Services/WorkflowStatusBuilder.cs # src/OrchardCore.Modules/OrchardCore.Workflows/WorkflowPruning/ViewModels/WorkflowPruningViewModel.cs # src/OrchardCore/OrchardCore.Workflows.Abstractions/WorkflowPruning/Services/IWorkflowPruningManager.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not incur merge conflicts in PRs if we are lucky
@sebastienros Yes. If there is, it should be easy conflict. If you are good with this PR, please merge or approve. |
I did, but GH failed. I hist approve with comment, and it only wrote the comment. Because there are too many files in the page. |
Wait for another approval though, maybe someone has other things to say |
This pull request has merge conflicts. Please resolve those before requesting a review. |
Since it's impossible to review this on GitHub, and tedious in a Git client, please confirm that these are the only changes:
If yes, then OK to merge by me after fixing the conflict. I fixed some formatting in the latter FYI, since commenting them wouldn't even work due to the size of the diff. |
That is correct @Piedone . I'll merge this after the build passes. |
No description provided.