Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable implicit usings #16574

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Enable implicit usings #16574

merged 5 commits into from
Aug 16, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@MikeAlhayek MikeAlhayek changed the title Ma/enable implicit usings Enable implicit usings Aug 15, 2024
Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

# Conflicts:
#	src/OrchardCore.Modules/OrchardCore.Workflows/WorkflowPruning/Drivers/WorkflowPruningDisplayDriver.cs
#	src/OrchardCore.Modules/OrchardCore.Workflows/WorkflowPruning/Services/WorkflowPruningBackgroundTask.cs
#	src/OrchardCore.Modules/OrchardCore.Workflows/WorkflowPruning/Services/WorkflowStatusBuilder.cs
#	src/OrchardCore.Modules/OrchardCore.Workflows/WorkflowPruning/ViewModels/WorkflowPruningViewModel.cs
#	src/OrchardCore/OrchardCore.Workflows.Abstractions/WorkflowPruning/Services/IWorkflowPruningManager.cs
Copy link
Member

@sebastienros sebastienros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not incur merge conflicts in PRs if we are lucky

@MikeAlhayek
Copy link
Member Author

@sebastienros Yes. If there is, it should be easy conflict.

If you are good with this PR, please merge or approve.

@sebastienros
Copy link
Member

I did, but GH failed. I hist approve with comment, and it only wrote the comment. Because there are too many files in the page.

@sebastienros
Copy link
Member

Wait for another approval though, maybe someone has other things to say

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@Piedone
Copy link
Member

Piedone commented Aug 16, 2024

Since it's impossible to review this on GitHub, and tedious in a Git client, please confirm that these are the only changes:

  • <ImplicitUsings>enable</ImplicitUsings>
  • Removing a bunch of namespace imports.
  • The clean-up from 2176b76

If yes, then OK to merge by me after fixing the conflict.

I fixed some formatting in the latter FYI, since commenting them wouldn't even work due to the size of the diff.

@MikeAlhayek
Copy link
Member Author

Since it's impossible to review this on GitHub, and tedious in a Git client, please confirm that these are the only changes:

* `<ImplicitUsings>enable</ImplicitUsings>`

* Removing a bunch of namespace imports.

* The clean-up from [2176b76](https://github.com/OrchardCMS/OrchardCore/commit/2176b7606c5598cef729d0d2e3c52107b3af3aa3)

If yes, then OK to merge by me after fixing the conflict.

That is correct @Piedone . I'll merge this after the build passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants