Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use extension method to update OpenId application descriptor #11721

Merged
merged 2 commits into from
May 19, 2022
Merged

Use extension method to update OpenId application descriptor #11721

merged 2 commits into from
May 19, 2022

Conversation

MichaelPetrinolis
Copy link
Contributor

reuse logic used in ApplicationController.Edit() also in ApplicationController.Create() and OpenIdApplicationStep

closes #11720

@MichaelPetrinolis
Copy link
Contributor Author

I don't now why the tests fail, my changes should not be the reason.

@sebastienros sebastienros merged commit 4b4a06e into OrchardCMS:main May 19, 2022
@kevinchalet kevinchalet added this to the 1.x milestone May 19, 2022
@kevinchalet
Copy link
Member

Thanks for your PR! 👏🏻

@Skrypt Skrypt modified the milestones: 1.x, 1.5 Nov 4, 2022
@MichaelPetrinolis MichaelPetrinolis deleted the fix_OpenIdApplicationStep_to_remove_unused_permissions branch February 20, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinchalet kevinchalet Awaiting requested review from kevinchalet

Assignees
No one assigned
Labels
bug 🐛 OpenId
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

Fix OpenIdApplicationStep to remove permissions for flows that are no longer enabled
4 participants
@MichaelPetrinolis @kevinchalet @sebastienros @Skrypt