OpenID Recipes: use step model instead of view model, support update

[kaipm]

Changes in the pull request

• Add unit tests for OpenID scopes
• Add unit tests for OpenID apps
• Replace OpenIdScopeStepViewModel with OpenIdScopeStepModel in recipe
• Replace CreateOpenIdApplicationViewModel with OpenIdApplicationStepModel in recipe
• Adjust OpenIdScopeStep to support update
• Adjust OpenIdApplicationStep to support update
• Adjust OpenIdApplicationStep to include importing scopes, which were not imported before

This is another part of #6364

[deanmarcussen]

Are the new step models the same as the old viewmodels that were used?

i.e. is it non breaking on existing recipes, or?

But awesome looks really good thanks

[sebastienros]

@kaipm we just need to understand if it is breaking anything so we can document the upgrade steps accordingly.

[kaipm]

Yes, they are. I did unit tests before making any changes, to make sure I match the old structure.

However, there is a small difference in the behaviour:

The following example was necessary to add role1 before the PR, it still works after the PR:

"roleEntries": [
  {
    "name": "role1",
    "selected": true
  }
]

The following two examples did not add role1 before the PR. But after the PR they will add role1 because selected is ignored completely:

"roleEntries": [
  {
    "name": "role1",
    "selected": false
  }
]

"roleEntries": [
  {
    "name": "role1"
  }
]

Edit: I forgot, OpenID Scopes were not imported at all, so those were newly added. I made them similar to the role entries, to be a little consistent:

"scopeEntries": [
  {
    "name": "scope1"
  }
]

[hishamco]

LGTM, after removing the extra whitespaces

[kaipm]

@hishamco, I did all the proposed changes.

I also removed some line breaks between IF-statements too, because most were without already. I hope that's fine!

[hishamco]

Thanks @kaipm for the PR, we will merge this ASAP