Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use step model for OpenId server settings deploy #10109

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Use step model for OpenId server settings deploy #10109

merged 2 commits into from
Aug 13, 2021

Conversation

kaipm
Copy link
Contributor

@kaipm kaipm commented Aug 13, 2021

This is another part of #6364

The deployment source currently exports OpenIdServerSettings directly, whereas the recipe step parses OpenIdServerSettingsStepModel.

Most properties work fine anyway, but the endpoint settings are ignored by the recipe step.

Example of previous export (ignored by recipe import):

...
"AuthorizationEndpointPath": "/connect/authorize",
"LogoutEndpointPath": "/connect/logout",
"TokenEndpointPath": "/connect/token",
"UserinfoEndpointPath": null,
...

Example of fixed export:

...
"EnableTokenEndpoint": true,
"EnableAuthorizationEndpoint": true,
"EnableLogoutEndpoint": true,
"EnableUserInfoEndpoint": false,
...

The endpoint paths are no longer exported at all, because the recipe step only reads the boolean values, and uses constants for the paths if a flag is true.

The UI does not allow to edit the endpoint paths either, so I'm hoping this fix is fine.

@kaipm kaipm requested a review from kevinchalet as a code owner August 13, 2021 15:45
@agriffard agriffard merged commit bb87856 into OrchardCMS:main Aug 13, 2021
@kaipm kaipm deleted the fix-openid-deploy branch August 13, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants