Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust OpenId server settings deploy source to match recipe step, #6364 #10089

Merged
merged 5 commits into from
Aug 12, 2021
Merged

Adjust OpenId server settings deploy source to match recipe step, #6364 #10089

merged 5 commits into from
Aug 12, 2021

Conversation

kaipm
Copy link
Contributor

@kaipm kaipm commented Aug 11, 2021

Refactor OpenIdServerDeploymentSource to be readable by the current implementation of OpenIdServerSettingsStep.

The server settings deployment source output is changed from:

...
"steps": [
  {
    "name": "OpenIdServer",
    "OpenIdServer": {
        ...
    }
  }
]

to:

...
"steps": [
  {
    "name": "OpenIdServerSettings",
    ...
  }
]

Partially deals with existing issue, see #6364

@kaipm kaipm requested a review from kevinchalet as a code owner August 11, 2021 00:00
@kaipm
Copy link
Contributor Author

kaipm commented Aug 12, 2021

It seems the C# 9.0 new() shorthand is the issue, in the new file MemoryFileBuilder...

I'm sorry, already on it to push a fix.

@agriffard agriffard merged commit 06ee3a9 into OrchardCMS:main Aug 12, 2021
@kaipm kaipm deleted the fix-openid-deploy branch August 12, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants