The ScriptsMiddleware(s) should be replaced by endpoints

[sebastienros]

No need to create a middleware that is impacting the stack size to serve script files. We can register the endpoint routes directly and invoke a delegate.

These methods should also not do string concatenation to render the files. They could precompute the utf8 string (private static ReadOnlySpan<byte> => "value"u8;) and call WriteAsync() for each segment instead.

[sebastienros]

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Liquid/ScriptsMiddleware.cs

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Facebook/ScriptsMiddleware.cs

[Piedone]

The endpoints in the Content module can serve as examples.

[DonaldDWebster]

Is this issue still open? I was thinking about picking it up as a first issue if so, I wanted to check first since I do not see any references to OrchardCore.Liquid.ScriptsMiddleWare

Forgive my ignorance and thank you for the help.

[hishamco]

You can go for it

[Piedone]

Yep, thank you! Be sure to check out https://docs.orchardcore.net/en/latest/guides/contributing/contributing-code/ first.

[DonaldDWebster]

My progress has been slow, I don't think I can complete it in a reasonable amount of time 😅. My sincere apologies.

[Piedone]

Perhaps try to follow the pattern of #15294. This should be more or less copy-pasting to endpoints from the middlewares.

[jbytes1027]

@DonaldDWebster are you still planning on working on this? I'm happy to finish this for you.

[DonaldDWebster]

@DonaldDWebster are you still planning on working on this? I'm happy to finish this for you.

Please feel free to pick it up