Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated validation messages when registering as new user #11765

Closed
gvkries opened this issue May 25, 2022 · 1 comment · Fixed by #11766
Closed

Duplicated validation messages when registering as new user #11765

gvkries opened this issue May 25, 2022 · 1 comment · Fixed by #11766
Milestone
1.4

Comments

@gvkries
Copy link
Contributor

gvkries commented May 25, 2022

Describe the bug

The user registration is validating the email address of new users in two places, which will cause two validation messages on the summary view:

  1. In the RegisterViewModel class which is an IValidatableObject
  2. In the RegistrationController with the addition of checking for duplicated email addresses.

To Reproduce

Enable user registration and leave the email field empty.
gvkries added a commit to gvkries/OrchardCore that referenced this issue May 25, 2022
@gvkries
Removes duplicated email validation in user registration.
696196a 
Fixes OrchardCMS#11765
@gvkries gvkries mentioned this issue May 25, 2022
Merged
@Skrypt Skrypt closed this as completed May 25, 2022
@gvkries
Copy link
Contributor Author

gvkries commented May 25, 2022

This isn't fixed!

@Skrypt Skrypt reopened this May 25, 2022
sebastienros pushed a commit that referenced this issue May 26, 2022
@gvkries
Removes duplicated email validation in user registration. (#11766)
768b0e0 
Fixes #11765

Co-authored-by: Georg von Kries <georg.von.kries@creativbox.net>
@sebastienros sebastienros added this to the 1.4 milestone May 26, 2022
@SusanEnneking SusanEnneking mentioned this issue Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

Removes duplicated email validation in user registration. gvkries/OrchardCore
3 participants
@sebastienros @Skrypt @gvkries