#4852: Wrap IOrchardShellEvents in a work context

[harmony7]

This is a fix for #4852

This fixes some of the problems we are seeing relating to being unable to inject HttpContextBase during IOrchardShellEvents.

This has mainly been a problem when attempting to access ContentManager or site settings in Data Migrations, such as seen in #5305 #5490 #5528.

We seem to only be hitting the problem when Orchard is compiled under VS2015, but this is probably the correct behavior even when building under previous environments.

[jersiovic]

It works perfect, the problems has disappeared.
Thank you so much!!!

[sebastienros]

I think we should try your change and revert this: ce630f9

And also revert all the other changes related to HttpContext resolution, including the Shape Tracing one in the dev branch.

[harmony7]

@sebastienros is there anything else i need to do, or are you guys going to be doing the reverting ?

[sebastienros]

If you want to try to revert all the changes and ensure it still fixes the reported changes then I would be more than happy. On the 1.9.x branch.

[harmony7]

I can try reverting ce630f9. There is also 4b59569. Are there any other change sets?

[harmony7]

Actually, though, this problem (injecting ContentManager in Migrations) occurs in 1.8 on VS2015 too. My change fixes it on that as well, and since 1.8 obviously doesn't have any of the recent HttpContext changes, I'm pretty sure this is all we need.

[sebastienros]

Would you be able to revert all these unnecessary changes then? //cc @jtkech

[sebastienros]

I will try to add your change here, and also revert the fixes for the 3 issues you mentioned if I can't repro them.