This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Allow to configure VolumeMount for backrest-sidecar container #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AKamyshnikova is that PR ready for review ? |
cscetbon
reviewed
Dec 10, 2021
| } | ||
|
|
||
| if cc.Spec.BackRestSidecar.Resources != nil { | ||
| container.Resources = *cc.Spec.BackRestSidecar.Resources | ||
| } | ||
|
|
||
| container.VolumeMounts = generateContainerVolumeMount(cc, backrestContainer) | ||
| container.VolumeMounts = append(container.VolumeMounts, generateContainerVolumeMount(cc, backrestContainer)...) |
There was a problem hiding this comment.
@AKamyshnikova I don't see a test that verifies the volumes mounted on backrest container. Can you add one ?
cscetbon
suggested changes
Dec 13, 2021
|
@AKamyshnikova I'm closing this PR. Please reopen it, based on the current master branch, if you still want it to be merged in. Thanks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
In CassandraCluster extend section for BackRestSidecar to pass VolumeMounts.
Fixes: #381
Checklist