Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OUDS] Add color background helpers to the Colors tokens PR #2831

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[OUDS] Add color background helpers to the Colors tokens PR #2831

merged 1 commit into from
Jan 17, 2025

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 6, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Remaining tasks and questions

⚠️ Questions:

  • Do we keep the switch to set text color inside _color-bg.scss ? Any better solution ?

Tasks:

Done list

The following was done in the PR:

  • Changed all the .text-bg-* occurrences in the docs
  • Introduced documentation for Color and Background
  • Uncommented some links
  • Reviewed the wording a bit

To be done after the PR is merged

  • Uncomment things when Badge are defined.
  • Uncomment things when Cards are defined.

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

@louismaximepiton louismaximepiton added 📖 documentation Improvements or additions to documentation css labels Jan 6, 2025
@louismaximepiton louismaximepiton added this to the OUDS milestone Jan 6, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 324d023
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/677c1960b7bf830008531d51
😎 Deploy Preview https://deploy-preview-2831--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton changed the base branch from ouds/main-lmp-tokens-colors to ouds/main-lmp-tokens-colors-text-utilities January 6, 2025 17:59
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from 71d87cf to bc5aa4b Compare January 7, 2025 10:44
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-bg-helpers branch from 324d023 to 66da320 Compare January 7, 2025 10:55
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from bc5aa4b to df79d2c Compare January 7, 2025 11:07
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-bg-helpers branch from 66da320 to c6269db Compare January 7, 2025 11:08
@louismaximepiton louismaximepiton marked this pull request as ready for review January 7, 2025 11:14
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from df79d2c to 6b27bac Compare January 8, 2025 10:47
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-bg-helpers branch from c6269db to c64f03a Compare January 8, 2025 10:54
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from 6b27bac to 77424c7 Compare January 8, 2025 17:31
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-bg-helpers branch from c64f03a to 98f2509 Compare January 8, 2025 17:32
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-utilities branch from 77424c7 to da1f218 Compare January 9, 2025 09:46
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-colors-text-bg-helpers branch from 98f2509 to 6a2b3d5 Compare January 9, 2025 09:47
@vprothais vprothais merged commit 664b27f into ouds/main-lmp-tokens-colors-text-utilities Jan 17, 2025
9 of 10 checks passed
@vprothais vprothais deleted the ouds/main-lmp-tokens-colors-text-bg-helpers branch January 17, 2025 10:52
louismaximepiton added a commit that referenced this pull request Jan 20, 2025
@louismaximepiton
Add color background helpers to the Colors tokens PR (#2831)
f5fae42
louismaximepiton added a commit that referenced this pull request Jan 20, 2025
@louismaximepiton
Add color background helpers to the Colors tokens PR (#2831)
d3e7de0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprothais vprothais vprothais approved these changes

Assignees
No one assigned
Labels
css 📖 documentation Improvements or additions to documentation
Projects
[OUDS] Project
Status: Done
Milestone
OUDS
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @vprothais