Fix --expires-on flag parsing #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschwartz
commented
Feb 25, 2020
| var apiClient utl.APIer | ||
| var out observ.OutputWriter | ||
| var ApiClient utl.APIer | ||
| var Out observ.OutputWriter |
There was a problem hiding this comment.
Needed to make these public, so I can mock them in tests
(our lease service relies on global variables)
eschwartz
commented
Feb 25, 2020
| @@ -31,7 +31,7 @@ func (s *LeasesService) CreateLease(principalID string, budgetAmount float64, bu | |||
|
|
|||
| expiry, err := s.Util.ExpandEpochTime(expiresOn) | |||
|
|
|||
| if err != nil && expiry > 0 { | |||
| if err == nil && expiry > 0 { | |||
eschwartz
commented
Feb 25, 2020
| ) | ||
|
|
||
| func TestLeasesCreate(t *testing.T) { | ||
| cli := NewCLITest(t) |
There was a problem hiding this comment.
Put together a quick happy-path test for dce leases create. Could/should be expanded in the future, to cover other use cases
eschwartz
commented
Feb 25, 2020
| @@ -24,7 +24,7 @@ func (s *AccountsService) AddAccount(accountID, adminRoleARN string) { | |||
| }, | |||
| } | |||
| params.SetTimeout(5 * time.Second) | |||
| _, err := apiClient.PostAccounts(params, nil) | |||
| _, err := ApiClient.PostAccounts(params, nil) | |||
There was a problem hiding this comment.
Needed to make these public, so I can mock them in tests
(our lease service relies on global variables)
nathanagood
approved these changes
Feb 26, 2020
| @@ -31,7 +31,7 @@ func (s *LeasesService) CreateLease(principalID string, budgetAmount float64, bu | |||
|
|
|||
| expiry, err := s.Util.ExpandEpochTime(expiresOn) | |||
|
|
|||
| if err != nil && expiry > 0 { | |||
| if err == nil && expiry > 0 { | |||
bf28aa8 to
2e0c4c4
Compare
2e0c4c4 to
db9ae00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #77
Add basic integration test coverage around
dce leases createTypes of changes
Checklist
README.md, inline comments, etc.)CHANGELOG.mdunder a## nextrelease, with a short summary of my changesRelevant Links