Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/dce deploy still requires gh token #57

Merged
merged 3 commits into from
Jan 2, 2020
Merged

Bug/dce deploy still requires gh token #57

merged 3 commits into from
Jan 2, 2020

Conversation

joshmarsh
Copy link
Contributor

@joshmarsh joshmarsh commented Jan 2, 2020

Proposed changes

This PR replaces calls to the Github GraphQL API by using the public <repo>/releases/latest/download/<asset> url to download deployment assets.

We were previously using Github's GraphQL API to download assets during dce deployment. This allowed us to authenticate with our private repo using Github Personal Access Tokens. Now that the repo is public, we no longer need or want to use an API that requires auth tokens for downloading assets.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

Copy link
Contributor

@nathanagood nathanagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fast fix.

@joshmarsh joshmarsh merged commit 33c32eb into Optum:master Jan 2, 2020
@joshmarsh joshmarsh deleted the bug/dce-deploy-still-requires-gh-token branch January 2, 2020 19:41
@eschwartz
Copy link
Contributor

sweet, thanks @joshmarsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants