Setting aws session region from config #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmarsh
commented
Dec 3, 2019
| @@ -35,6 +35,7 @@ func New(config *configs.Root, configFile string, observation *observ.Observatio | |||
| if err != nil { | |||
| log.Fatalf("Failed to initialize AWS Session: %s", err) | |||
| } | |||
| awsSession.Config.Region = config.Region | |||
There was a problem hiding this comment.
The shared credentials provider seems to be loading credentials from ~/.aws, but not the region. I also don't see anything in the code suggesting that it is loading the region.
There was a problem hiding this comment.
Yeah, it might not be configured the regions from the credentials file.
There's actually a few other places, though, where we set this default to us-east-1. I'd rather this isn't scattered all over the code base. Can we get it centralized in a single spot somewhere?
eg
Line 18 in 9757e4a
Line 31 in 9757e4a
eschwartz
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist
README.md, inline comments, etc.)CHANGELOG.mdunder a## nextrelease, with a short summary of my changesDependencies and Blockers
Relevant Links
Further comments