Deploy & other basic commands #4
Conversation
|
|
||
| func (s *LeasesService) LoginToLease(loginAcctID, loginLeaseID string, loginOpenBrowser bool) { | ||
| if loginAcctID != "" && loginLeaseID != "" { | ||
| log.Println("Please specify either --lease-id or --acctount-id, not both.") |
There was a problem hiding this comment.
The endpoint for this will only be based on the lease ID. I guess we could go the other way too but that isn't the current plan.
pkg/service/accounts.go
Outdated
| }) | ||
|
|
||
| body, _ := ioutil.ReadAll(response.Body) | ||
| fmt.Println("Response: ", response) |
There was a problem hiding this comment.
I would prefer the output to only be json. Then I can pipe it our output it more easily.
| fmt.Println("Posting to: ", accountsFullURL) | ||
| fmt.Println("Post body: ", requestBody) | ||
|
|
||
| response := s.Util.Request(&util.ApiRequestInput{ |
There was a problem hiding this comment.
We should be looking for an err here? What happens if this request fails?
Exit codes should not be 0 and the appropriate error message printed.
| } | ||
|
|
||
| // Create API request | ||
| req, err := http.NewRequest(input.Method, input.Url, nil) |
There was a problem hiding this comment.
Where we are collecting an err we should be testing that its null before continuing.
There was a problem hiding this comment.
I'll clean up the error handling and logging once I write some tests for this. I neglected those things since there was a lot of discovery work here and because we've gone back and forth a bit on the requirements for the CLI.
|
@kddejong, @joshmarsh - Let's call this sufficient as a POC. Please have tests and error handling as a follow up in your coming PR. |
Goal
POC the core functionality of the CLI.
Important Notes
Current Functionality:
dce inituses an interactive prompt to generate a config filedce deploydeploys dce to a new master account based on credentials in the config file. Terraform and code artifacts are downloaded from the latest github release.dce authopens a web browser to the authentication (SSO) url provided in the config file. User is instructed to login and then copy/paste their API credentials into the terminal. This is not yet integrated with the backend auth solution.dce accounts add --account-id <string> --admin-role-arn <string>adds an existing account to the accounts pool Bug: The codebuild reset is currently failing to trigger on master accounts deployed by the cli.dce leases create --budget-amount <float> --budget-currency <string> --email <stringArray> --principle-id <string>creates a leasedce leases login [--account-id <string> | --lease-id <string>] --open-browserreturns temporary credentials for a leased account. Opens a browser to the console if the --open-browser flag is present. This is not yet integrated with the backend auth solution.dce leases end --account-id <string> --principle-id <string>ends a leasedce accounts remove --account-id <string>Next Steps:
dce deployflags/interactive prompt from variables.tf and API client code/commands from swagger.