Feature/cross patform testing #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschwartz
reviewed
Nov 13, 2019
| @@ -2,6 +2,18 @@ | |||
|
|
|||
| This is the CLI for [DCE](https://github.com/Optum/dce) by Optum. For usage information, view the complete [command reference](./docs/dce.md). | |||
|
|
|||
| # Feature Availability | |||
eschwartz
reviewed
Nov 13, 2019
README.md
Outdated
|
|
||
| | Feature | *nix | Windows | | ||
| | ----------- | ----------- | ----------- | | ||
| | Deployment (`dce system deploy`) | Available | Unavailable | |
There was a problem hiding this comment.
Is there a Github issue or something we could point to here,
eg. if someone sees this and wants to contribute to fix it?
eschwartz
reviewed
Nov 13, 2019
| -l, --lease-id string Lease ID for the account to login to | ||
| -b, --open-browser Opens web broswer to AWS console instead of printing credentials | ||
| -h, --help help for login | ||
| -b, --open-browser Opens web broswer to AWS console instead of printing credentials |
eschwartz
reviewed
Nov 13, 2019
docs/dce_usage.md
Outdated
| ### Options | ||
|
|
||
| ``` | ||
| -e, --end-date float The end date of the window over which usage information will be queried. |
There was a problem hiding this comment.
Are these epoch timestamps? Might be worth calling out here
As a future feature, it might be nice to have some more human-usable options (eg. --since=3d)
eschwartz
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
#21
#19