feat: do not rely on comma to encode jobid in progress fixes #2003 #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdatta
reviewed
Mar 24, 2021
lib/queue.js
Outdated
| // New way to send progress message data | ||
| try { | ||
| const { progress, jobId } = JSON.parse(message); | ||
| this.emit('global:progress', jobId, JSON.parse(progress)); |
There was a problem hiding this comment.
Do we need this second JSON.parse, since we are sending progress this time, not progressJSON string.
There was a problem hiding this comment.
oh yes, you are right, some test should have caught this error though, I will fix it.
abdatta
approved these changes
Mar 24, 2021
papandreou
added a commit
to papandreou/bull
that referenced
this pull request
Apr 27, 2021
* develop: (39 commits) chore(release): 3.22.3 [skip ci] fix(delayed): re-schedule updateDelay in case of error fixes OptimalBits#2015 chore(release): 3.22.2 [skip ci] chore: fix github token chore: correct release branch test: increase timeout in test chore: add semantic release scripts fix(obliterate): obliterate many jobs fixes OptimalBits#2016 3.22.1 chore: upgrade dependencies chore: update CHANGELOG fix(obliterate): remove repeatable jobs fixes OptimalBits#2012 docs: fix typo docs: update README.md docs: updated README.md Update README.md 3.22.0 docs: update CHANGELOG feat: do not rely on comma to encode jobid in progress fixes OptimalBits#2003 (OptimalBits#2004) 3.21.1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.