Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rate limiting? #329

Closed
afrozl opened this issue Aug 4, 2016 · 3 comments
Closed

rate limiting? #329

afrozl opened this issue Aug 4, 2016 · 3 comments
Labels
enhancement PR REQUEST

Comments

@afrozl
Copy link

afrozl commented Aug 4, 2016

Is it possible to limit a job (keyed on an argument) to only run x times a period? does bull have a plugin framework so commonly used functions can be shared across jobs?
@zoell
Copy link

zoell commented Aug 22, 2016

I am also interested in this. Have you ever find a solution with bull or any other library?

@bradvogel
Copy link
Contributor

Have you seen #335 that just got merged? You can give the job a unique key and a delay, so if you add a job with that same id that is currently queued, it won't do anything. So basically throttling. cc @pricj004

@doublerebel doublerebel mentioned this issue Nov 14, 2016
Closed
@manast
Copy link
Member

manast commented Nov 25, 2016 •
edited
Loading

Closing due to being a duplicate of #362

@manast manast closed this as completed Nov 25, 2016
leahciMic pushed a commit to leahciMic/bull that referenced this issue Nov 28, 2016
Add support for rate limiting
eb74748 
Fix OptimalBits#362
Fix OptimalBits#329

This commit adds support for rate limiting of a queue. The rate limit
applies to each instance of the queue. If you have 3 threads processing
the queue, and you want to limit your jobs to 1 per second, it will be
1 job per second amongst the 3 threads.

queue#process first argument has been changed to an options object, and
concurrency now resides within this object, as well as the new rate
limiting options. (If a number is specified as the first argument to
queue#process, it will be treated as the old version of the API which I
have deprecated in favor of passing in the options object).
@leahciMic leahciMic mentioned this issue Nov 28, 2016
Closed
leahciMic pushed a commit to leahciMic/bull that referenced this issue Feb 15, 2017
Add support for rate limiting
36e9cb0 
Fix OptimalBits#362
Fix OptimalBits#329

This commit adds support for rate limiting of a queue. The rate limit
applies to each instance of the queue. If you have 3 threads processing
the queue, and you want to limit your jobs to 1 per second, it will be
1 job per second amongst the 3 threads.

queue#process first argument has been changed to an options object, and
concurrency now resides within this object, as well as the new rate
limiting options. (If a number is specified as the first argument to
queue#process, it will be treated as the old version of the API which I
have deprecated in favor of passing in the options object).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement PR REQUEST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@manast @bradvogel @zoell @afrozl