Infer additional consent flags & gate PS join IG #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapo
commented
Jan 13, 2025
769b977 to
5c4c55d
Compare
71b88f0 to
d9f4bcc
Compare
jmarc101
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the the sdk to gate
joinAdInterestGroupsbased on all the operations done by the iframe it injects:To do so those consents are gathered depending on the detected jurisdiction similarly to existing "deviceAccess" flag but by looking up different purposes granted to either publisher or given vendor ID.
They default to be allowed (similarly to when we introduced device access) for backward compatibility.
Eventually those will be moved directly to the javascript running in the join iframe to degrade the behavior rather than gating it fully (eg if only measurement is denied, we would only prevent sharedStorage reporting worklet from running and not loose the join). This will also allow other integration points to benefit from consent handling (eg injecting the iframe directly rather than going through the SDK).