Latest Actions Updates #524
Conversation
| @@ -707,6 +714,7 @@ type ContactUpdateInput struct { | |||
| type CustomActionsTriggerDefinitionCreateInput struct { | |||
| AccessControl *CustomActionsTriggerDefinitionAccessControlEnum `json:"accessControl,omitempty" yaml:"accessControl,omitempty" example:"admins"` // The set of users that should be able to use the trigger definition (Optional) | |||
| ActionId *Nullable[ID] `json:"actionId,omitempty" yaml:"actionId,omitempty" example:"Z2lkOi8vc2VydmljZS8xMjM0NTY3ODk"` // The action that will be triggered by the Trigger Definition (Optional) | |||
| ApprovalConfig *ApprovalConfigInput `json:"approvalConfig,omitempty" yaml:"approvalConfig,omitempty"` // Config for approval of action (Optional) | |||
There was a problem hiding this comment.
This does support null but @BigBlue79 says it doesn't do what i think it does so leaving it as 3 state instead of support json null.
| @@ -747,6 +757,7 @@ type CustomActionsWebhookActionCreateInput struct { | |||
|
|
|||
| // CustomActionsWebhookActionUpdateInput Inputs that specify the details of a Webhook Action you wish to update | |||
| type CustomActionsWebhookActionUpdateInput struct { | |||
| Async *Nullable[bool] `json:"async,omitempty" yaml:"async,omitempty" example:"false"` // Whether the action expects an additional, asynchronous response upon completion (Optional) | |||
There was a problem hiding this comment.
Need to test if the state of json null works here to "unset" to the default
There was a problem hiding this comment.
no, validates: { allow_null: false }
(and in general I think that's the safer assumption?)
There was a problem hiding this comment.
So, per our slack discussion, this should just be *bool, right?
| @@ -737,6 +746,7 @@ type CustomActionsTriggerDefinitionUpdateInput struct { | |||
|
|
|||
| // CustomActionsWebhookActionCreateInput Specifies the input fields used in the `customActionsWebhookActionCreate` mutation | |||
| type CustomActionsWebhookActionCreateInput struct { | |||
| Async *bool `json:"async,omitempty" yaml:"async,omitempty" example:"false"` // Whether the action expects an additional, asynchronous response upon completion (Required) | |||
There was a problem hiding this comment.
the "(Required)" should probably say "(Optional, defaults to false)"... we should be able to get that out of the generator tbh, the default value is present in the schema
There was a problem hiding this comment.
Ok i'll see if i can add this
Resolves #
Problem
opslevel-go is not up to date with the API spec
Solution
Run the code generator
Checklist