Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add flexStacker fill and empty #17561

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

sfoster1
Copy link
Member

These commands allow for state manipulation of the stacker's labware pool. fill adds labware and empty removes labware. The commands require the pool to have already been configured and will fail if not. We'll have to at some point augment these with error recovery and handling for physical failures.

Closes EXEC-1213

These commands allow for state manipulation of the stacker's labware
pool. fill adds labware and empty removes labware. The commands require
the pool to have already been configured and will fail if not. We'll
have to at some point augment these with error recovery and handling for
physical failures.

Closes EXEC-1213
@sfoster1 sfoster1 requested review from a team as code owners February 20, 2025 17:41
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.52%. Comparing base (829abc6) to head (0d1e632).
Report is 10 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17561      +/-   ##
==========================================
- Coverage   63.62%   63.52%   -0.10%     
==========================================
  Files        2838     2840       +2     
  Lines      218019   218535     +516     
  Branches    18107    18125      +18     
==========================================
+ Hits       138704   138832     +128     
- Misses      79122    79510     +388     
  Partials      193      193              
Flag Coverage Δ
protocol-designer 18.86% <ø> (+0.01%) ⬆️
step-generation 4.34% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

description=(
"The new count of labware in the pool. If None, default to an empty pool. If this number is "
"larger than the amount of labware currently in the pool, default to the smaller amount. "
"Do not use the value in the parameters as an outside observer; instead, use the count value "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not understand this comment 🤷‍♀️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which part of it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the purpose of this to enable "partial" emptying of a stacker in the future?

)

# TODO: propagate the limit on max height of the stacker
count = params.count if params.count is not None else 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be a static variable somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could. It should imminently become a hardware controller call somewhere though, like in days or weeks, so I think we can get away with it just being a number.

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good! just a few requests please ;-)

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward, looks good on my end.

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward overall, thanks.

description=(
"The new count of labware in the pool. If None, default to an empty pool. If this number is "
"larger than the amount of labware currently in the pool, default to the smaller amount. "
"Do not use the value in the parameters as an outside observer; instead, use the count value "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the purpose of this to enable "partial" emptying of a stacker in the future?

@sfoster1
Copy link
Member Author

@CaseyBatten Yup!

@sfoster1 sfoster1 merged commit 4dd87df into edge Feb 21, 2025
72 checks passed
@sfoster1 sfoster1 deleted the exec-1213-stacker-fill-empty branch February 21, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants