-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add flexStacker fill and empty #17561
Conversation
These commands allow for state manipulation of the stacker's labware pool. fill adds labware and empty removes labware. The commands require the pool to have already been configured and will fail if not. We'll have to at some point augment these with error recovery and handling for physical failures. Closes EXEC-1213
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17561 +/- ##
==========================================
- Coverage 63.62% 63.52% -0.10%
==========================================
Files 2838 2840 +2
Lines 218019 218535 +516
Branches 18107 18125 +18
==========================================
+ Hits 138704 138832 +128
- Misses 79122 79510 +388
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more. |
description=( | ||
"The new count of labware in the pool. If None, default to an empty pool. If this number is " | ||
"larger than the amount of labware currently in the pool, default to the smaller amount. " | ||
"Do not use the value in the parameters as an outside observer; instead, use the count value " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not understand this comment 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which part of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the purpose of this to enable "partial" emptying of a stacker in the future?
) | ||
|
||
# TODO: propagate the limit on max height of the stacker | ||
count = params.count if params.count is not None else 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be a static variable somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could. It should imminently become a hardware controller call somewhere though, like in days or weeks, so I think we can get away with it just being a number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good! just a few requests please ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very straightforward, looks good on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward overall, thanks.
description=( | ||
"The new count of labware in the pool. If None, default to an empty pool. If this number is " | ||
"larger than the amount of labware currently in the pool, default to the smaller amount. " | ||
"Do not use the value in the parameters as an outside observer; instead, use the count value " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the purpose of this to enable "partial" emptying of a stacker in the future?
@CaseyBatten Yup! |
These commands allow for state manipulation of the stacker's labware pool. fill adds labware and empty removes labware. The commands require the pool to have already been configured and will fail if not. We'll have to at some point augment these with error recovery and handling for physical failures.
Closes EXEC-1213