-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer): remove dropdown menu for module quantity #17531
fix(protocol-designer): remove dropdown menu for module quantity #17531
Conversation
remove dropdown menu for module quantity close AUTH-1451
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17531 +/- ##
==========================================
- Coverage 26.17% 18.02% -8.16%
==========================================
Files 3191 3090 -101
Lines 230174 222921 -7253
Branches 9814 7005 -2809
==========================================
- Hits 60251 40178 -20073
- Misses 169898 182743 +12845
+ Partials 25 0 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
const numSlotsAvailable = getNumSlotsAvailable( | ||
modules, | ||
additionalEquipment, | ||
moduleModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with this change, doesn't that mean we can simplify getNumSlotsAvailable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still don't touch that part since the ticket only mentions to modules. i added my question to weekly meeting.
once i get an answer i will update getNumSlotsAvailable
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works but i think there is additional cleanup to be done:
getNumSlotsAvailable
can be simplified since we won't need to account for MoaM logic for modules anymore- the
createModuleWithNoSlot
thunk used inCreateNewProtocolWizard
is never called anymore since the modules will always have an assigned slot associated with them. So i recommend deleting that thunk
Overview
remove dropdown menu for module quantity and do a little bit refactoring.
remove the snackbar because it doesn't hit the module limit.
SelectModules still doing a lot of things in the component.
Refactoring is necessary to separate the UI and logic to enhance readability and maintainability in the future.
close AUTH-1451
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low