Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): translate continue button in network #17528

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

sfoster1
Copy link
Member

The continue button "continue" text in various network settings panels needs to come from the shared i18n source, which is where it is, not the device_settings i18n source, which is where it isn't. By knowing where continue isn't, we know where continue is, and by subtracting where continue isn't from where continue is we know where continue should be, and by making where continue should be go from where continue isn't to where continue is, eventually we end up where continue is.

testing

  • put this odd on a robot
  • from the settings screen, connect to wifi and check that continue is localized. This should now happen in the "join other network" screen and in the "select authentication type" screen
  • from the first-run experience, try to connect via ethernet while an ethernet cable is unplugged and note that "no data" is now localized
  • from the first-run experience, try to connect via wifi and note that the same things are now localized as in the setup screen

Closes RQA-3960

The continue button "continue" text in various network settings panels
needs to come from the shared i18n source, which is where it is, not the
device_settings i18n source, which is where it isn't. By knowing where
continue isn't, we know where continue is, and by subtracting where
continue isn't from where continue is we know where continue should be,
and by making where continue should be go from where continue isn't to
where continue is, eventually we end up where continue is.

Closes RQA-3960
@sfoster1 sfoster1 requested a review from a team as a code owner February 14, 2025 14:38
@sfoster1 sfoster1 requested review from jerader, skowalski08, koji and TamarZanzouri and removed request for a team February 14, 2025 14:38
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM :-) looks good as long as tested on the robot

@skowalski08
Copy link
Contributor

✅Validated “continue” text is localized in the ”join other network" screen and in the "select authentication type" screen
✅Verified that "no data" has been localized when ethernet is unplugged
✅Verified that the unboxing flow for wifi set up is consistent with settings wifi set up

LGTM

@sfoster1 sfoster1 merged commit 7974593 into chore_release-8.3.0 Feb 14, 2025
36 checks passed
@sfoster1 sfoster1 deleted the RQA-3960-fix-continue branch February 14, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants