Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes of this pull request introduce the two new settings 'tool_opencast/apitimeout' and 'tool_opencast/apiconnecttimeout'. Both to be set in milliseconds. 'tool_opencast/apitimeout' controls 'CURLOPT_TIMEOUT_MS' and 'tool_opencast/apiconnecttimeout' 'CURLOPT_CONNECTTIMEOUT_MS'.
The setting 'tool_opencast/connecttimeout' was dropped because it never had an effect (see #41) and the unit were seconds.
I manually tested the patch with netem/tc
During my work on this patch I discovered the following todos (which should be handled in separate issues/PRs):
$customconfigs
parameter handling (currently$customconfigs
is an all-or-noting decision, not possible to only set 'apitimeout' for example)