Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solidity linting using prettier #2697

Merged
merged 16 commits into from
Jun 7, 2021
Merged

Solidity linting using prettier #2697

merged 16 commits into from
Jun 7, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented May 27, 2021 •
edited
Loading

Use prettier-plugin-solidity to check and fix solidity style.

frangio
frangio reviewed May 27, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonably good but there are some issues. I've opened issues in the repository and will put this PR on hold for now.

contracts/metatx/MinimalForwarder.sol Outdated Show resolved Hide resolved
contracts/mocks/ERC721ReceiverMock.sol Outdated Show resolved Hide resolved
contracts/proxy/Proxy.sol Outdated Show resolved Hide resolved
contracts/proxy/Proxy.sol Outdated Show resolved Hide resolved
contracts/token/ERC1155/ERC1155.sol Outdated Show resolved Hide resolved
@frangio frangio added the on hold Put on hold for some reason that must be specified in a comment. label May 27, 2021
@frangio frangio removed the on hold Put on hold for some reason that must be specified in a comment. label Jun 7, 2021
@frangio frangio marked this pull request as ready for review June 7, 2021 14:57
@frangio frangio enabled auto-merge (squash) June 7, 2021 15:00
@frangio frangio disabled auto-merge June 7, 2021 15:32
@frangio frangio merged commit b0cf6fb into OpenZeppelin:master Jun 7, 2021
@Amxx Amxx deleted the experimental/prettier branch June 7, 2021 15:33
@frangio frangio mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @frangio