Migrate to Hardhat #2397
Merged
Migrate to Hardhat #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2168add.
nventuro
previously approved these changes
Oct 28, 2020
| // remove the default account from the accounts list used in tests, in order | ||
| // to protect tests against accidentally passing due to the contract | ||
| // deployer being used subsequently as function caller | ||
| contract(name, accounts => body(accounts.slice(1))); |
There was a problem hiding this comment.
I love this. @alcuadrado make this the default behavior pretty please
There was a problem hiding this comment.
I'm not sure I understand this. Is it like the contract thing in truffle?
There was a problem hiding this comment.
This, this is a truffle plugin. I was referring to the feature of hiding the default account however.
There was a problem hiding this comment.
It's kind of opinionated, and I suppose the goal of the Truffle plugins is to have as much compatibility as possible.
frangio
added a commit
that referenced
this pull request
Nov 11, 2020
frangio
added a commit
that referenced
this pull request
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently announced we will be focusing our upgradeability efforts around Contracts and the Upgrades plugins, and halting development of the OpenZeppelin CLI.
Thus, this PR migrates this project to use Hardhat, until recently known as Buidler. (We will actually be using Buidler until solidity-coverage upgrades, see sc-forks/solidity-coverage#541.)