-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer and Approve events are slightly different from ERC20 standard wiki (missing _) #370
Comments
Thanks for reporting @yaronvel! I've noticed this before, but I don't think it's an issue. The argument names are not included in the actual event data. They're only used when decoding it at the application level. See web3's |
Yeah, it is very minor issue. Anyway, just wanted to let you know. As you are already aware of it, i will close the issue. |
What do you mean with the unknown field name? Is it posible that it said |
If I use
|
…at's ok: OpenZeppelin/openzeppelin-contracts#370. Adapted tests so that they don't fail. refs #1
For example, you are using
from
instead of_from
inTransfer
event.See wiki here.
It could cause problems when parsing events with web3.
However, I am guessing this standard is not strictly followed and devs cannot rely on it anyway.
The text was updated successfully, but these errors were encountered: