Use 1 select() call and let it block #20
Conversation
vusb-daemon spends a lot of time looping since it has two separate select calls with short timeouts. Unify the two select calls and let it block to avoid needless CPU usage. xcdbus_pre_select is written to add to in-use fd_sets and nfds, so use that feature. xcdbus_post_select will loop over its registered watches checking for if the corresponding FD is set, so an extra FD in readfds is fine. udevfd can then be checked for events as is done currently. Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
|
Nice, I didn't realize xcdbus could do that! |
|
Oh, thanks for the pointer about the USB controller. The drivers from https://openxt.ainfosec.com/builds/windows/master/412/ didn't seem to work - assigning a USB device promptly reverted to unassigned. Drivers from https://openxt.ainfosec.com/builds/regular/master/1773/repository/packages.main/ didn't show a controller, so I didn't try assigning :( Assigning a flash drive works. I'll try out a few more. |
|
Device assignment and reassignment seems to be working. |
|
LGTM, merging soon. |
vusb-daemon spends a lot of time looping since it has two separate
select calls with short timeouts. Unify the two select calls and let it
block to avoid needless CPU usage.
xcdbus_pre_select is written to add to in-use fd_sets and nfds, so use
that feature. xcdbus_post_select will loop over its registered watches
checking for if the corresponding FD is set, so an extra FD in readfds
is fine. udevfd can then be checked for events as is done currently.
Signed-off-by: Jason Andryuk jandryuk@gmail.com
I haven't actually tested USB pass through with this change. Drivers from the ais build server seem to install in Windows, but I don't see a OpenXT USB Controller in device manager. The other PV drivers are running though.
Looking at strace after the change, the daemon seems to be reacting just fine.