Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated backend client #42

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: remove deprecated backend client #42

merged 1 commit into from
Dec 2, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 2, 2024

no longer used and missing in requirements.txt, started failing due to being deprecated and no longer a dependency of OVOS

Summary by CodeRabbit

  • New Features

    • Enhanced factory reset process with detailed checks for data removal (cache, logs, configuration).
    • Improved handling of SSH service enable/disable requests with GUI updates.
    • Added checks for user-defined scripts during reboot and shutdown requests.
  • Bug Fixes

    • Refined logging for deprecated reset requests from the GUI.
  • Refactor

    • Removed identity file management from factory reset logic.

Copy link
Contributor

coderabbitai bot commented Dec 2, 2024

Walkthrough

The changes in this pull request focus on the SystemEventsPlugin class within the ovos_PHAL_plugin_system/__init__.py file. Key modifications include the removal of identity file handling during factory resets, an expanded factory reset process with detailed data wiping operations, and refined methods for handling SSH requests and system reboot/shutdown operations. The changes enhance the overall robustness of system event management while eliminating previous identity file management.

Changes

File Path Change Summary
ovos_PHAL_plugin_system/init.py - Modified SystemEventsPlugin to remove identity file handling during factory resets.
- Expanded factory reset logic to include detailed data wiping operations and checks for JSON databases.
- Updated handle_ssh_enable_request and handle_ssh_disable_request to include subprocess calls.
- Enhanced handle_reboot_request and handle_shutdown_request with checks for user-defined scripts.
- Modified classes: SystemEventsValidator, SystemEventsPlugin, SystemEventsAdminValidator, SystemEventsAdminPlugin.

Poem

In the system's heart, a change took flight,
Identity files gone, making things right.
With a wipe and a clean, the data's set free,
SSH now dances, as smooth as can be.
A reboot, a shutdown, all handled with care,
Oh, what a joy, in the code we now share! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6ad4104 and 7c08eba.

📒 Files selected for processing (1)
  • ovos_PHAL_plugin_system/__init__.py (0 hunks)
💤 Files with no reviewable changes (1)
  • ovos_PHAL_plugin_system/init.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added fix and removed fix labels Dec 2, 2024
@JarbasAl JarbasAl merged commit 2ca9933 into dev Dec 2, 2024
6 checks passed
@JarbasAl JarbasAl deleted the JarbasAl-patch-1 branch December 2, 2024 19:53
@coderabbitai coderabbitai bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant