Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge backend into repo #4

Merged
merged 3 commits into from
May 9, 2023
Merged

Merge backend into repo #4

merged 3 commits into from
May 9, 2023

Conversation

YouriRombouts
Copy link
Collaborator

No description provided.

@YouriRombouts
Upload backend
63af4a4
@YouriRombouts
Add comment
6678f7a 
TODO comment regarding authentication via policy rather than hardcoding it.
@YouriRombouts
Put endpoints behind /api
572e85e
BrickPi
BrickPi approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@BrickPi BrickPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing anything glaring, so I'm going to approve it but wait until Wednesday to merge it just in case we get another person familiar with ASP to check it.

@Spartan322
Copy link
Member

Not sure why I was requested to review, I don't really know much about ASP, I ain't much of a web development guy.

@Spartan322 Spartan322 added the enhancement New feature or request label May 8, 2023
@ClarkeCode ClarkeCode merged commit 1b28f28 into OpenVicProject:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClarkeCode ClarkeCode ClarkeCode approved these changes

@BrickPi BrickPi BrickPi approved these changes

@Hop311 Hop311 Awaiting requested review from Hop311

@Spartan322 Spartan322 Awaiting requested review from Spartan322

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YouriRombouts @Spartan322 @ClarkeCode @BrickPi