Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock invention if limit is met when applying history (placeholder) #211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wvpm
Copy link
Contributor

@wvpm wvpm commented Oct 24, 2024

When history is applied (starting new game), inventions are unlocked if their limit condition is met.

The condition checking is limited only to checking 1 technology is present. Most vanilla inventions have such limits.
Some vanilla inventions have more complex limits, they will (perhaps incorrectly) not be unlocked.

Once the complete condition checking functionality is ready, that should be used instead.

@wvpm wvpm marked this pull request as ready for review October 25, 2024 09:25
@wvpm wvpm force-pushed the invent_at_start branch 2 times, most recently from 9259d74 to 1a87e5c Compare October 25, 2024 09:28
@wvpm wvpm enabled auto-merge October 25, 2024 09:29
@wvpm wvpm requested a review from Hop311 October 27, 2024 19:38
@wvpm wvpm added the enhancement New feature or request label Oct 30, 2024
Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this spams out 854 "Failed to parse limit for invention ..." warnings, if we can't reduce the fail rate then we might as well wait for the upcoming condition system to implement this properly

@Lizzie841
Copy link

When history is applied (starting new game), inventions are unlocked if their limit condition is met.

The condition checking is limited only to checking 1 technology is present. Most vanilla inventions have such limits. Some vanilla inventions have more complex limits, they will (perhaps incorrectly) not be unlocked.

Once the complete condition checking functionality is ready, that should be used instead.

It also depends on the chance being >0%, not just the limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants