Fix GitHub issue link formatting #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, errors were reported on a single line, where the inline code-fencing on message worked. The current logic is: The html fetcher throws FetchDocumentErrors, with the URL fenced with apostrophe `'`. Archivist collects these errors in InaccessibleContentError, which produces a multiline error message (generic text + foreach(\n- error)). Because the message is multiline now, the inline code fencing with backticks no longer worked. As a side effect, the GitHub URL identification included the closing '` in the URL. Without the ` the ' is not included either. Dropping the now invalid backticks resolves both issues. Fixes OpenTermsArchive#967
|
The issue is still present, for example in OpenTermsArchive/france-declarations#258 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, errors were reported on a single line, where the inline code-fencing on message worked.
The current logic is:
The html fetcher throws FetchDocumentErrors, with the URL fenced with apostrophe
'. Archivist collects these errors in InaccessibleContentError, which produces a multiline error message (generic text + foreach(\n- error)).Because the message is multiline now, the inline code fencing with backticks no longer worked.
As a side effect, the GitHub URL identification included the closing '` in the URL. Without the ` the ' is not included in the URL href.
So dropping the now invalid backticks resolves both the invalid backticks and wrong URL linking.
Fixes #967