Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTSDB 2.4.1 Remote Code Execution #2261

Closed
oxeye-daniel opened this issue Dec 12, 2022 · 25 comments
Closed

OpenTSDB 2.4.1 Remote Code Execution #2261

oxeye-daniel opened this issue Dec 12, 2022 · 25 comments

Comments

@oxeye-daniel
Copy link

During our research at Oxeye Security, we found that OpenTSDB is vulnerable to Remote Code Execution vulnerability by writing user-controlled input to Gnuplot configuration file and running Gnuplot with the generated configuration.

As we don't want to publish zero days on the web without first contacting you, please provide us with a secure email address so we can communicate the description, reproduction steps, and more.

This vulnerability was discovered by Gal Goldshtein and Daniel Abeles.

@johann8384
Copy link
Member

Is this a different issue than the one addressed here?

#2127

@oxeye-daniel
Copy link
Author

@johann8384 thanks for the quick response. The issue referenced in ticket #2127 was valid for OpenTSDB 2.4.0; we found a bypass for the restrictions posed by the fix suggested in the ticket, so the remote code execution is operational for version 2.4.1.

@manolama
Copy link
Member

manolama commented Dec 16, 2022 via email

@oxeye-daniel
Copy link
Author

Hi @manolama, we can't seem to see the email address for some reason.

@manolama
Copy link
Member

Hmm, thank you Github. @oxeye-daniel you can pull my netflix email from the git commit logs on the 3.0 branch. That one or the euphoria audio email.

@oxeye-daniel
Copy link
Author

Hi @manolama , any updates?

@oxeye-daniel
Copy link
Author

Hi @manolama, are there any updates?

@oxeye-daniel
Copy link
Author

Hi @johann8384 @manolama, is there any update? It's been three months already.

@deamerfire
Copy link

deamerfire commented Mar 20, 2023 via email

@oxeye-daniel
Copy link
Author

@johann8384 @manolama @deamerfire @Dieken any updates?

@johann8384
Copy link
Member

johann8384 commented Apr 10, 2023 via email

manolama added a commit to manolama/opentsdb that referenced this issue Apr 11, 2023
Regular expressions wouldn't catch the newlines or possibly other
control characters. Now we'll use the TAG validation code to make
sure the inputs are only plain ASCII printables first.
Fixes CVE-2018-12972, CVE-2020-35476
manolama added a commit that referenced this issue Apr 11, 2023
Regular expressions wouldn't catch the newlines or possibly other
control characters. Now we'll use the TAG validation code to make
sure the inputs are only plain ASCII printables first.
Fixes CVE-2018-12972, CVE-2020-35476
@oxeye-daniel
Copy link
Author

Hi @manolama, thanks for referencing those commits; how can you assist in opening the security advisory?

@oxeye-daniel
Copy link
Author

Hi @manolama; how can you assist in opening the security advisory?

@deamerfire
Copy link

deamerfire commented May 29, 2023 via email

@oxeye-daniel
Copy link
Author

Hi @deamerfire @johann8384 @manolama @Dieken ,
It's been almost six months since we alerted OpenTSDB of this vulnerability, and still no security advisory. Can you please open up one?

@Dieken
Copy link
Contributor

Dieken commented Jun 12, 2023

Not maintainer of OpenTSDB.

I guess @manolama got your message, just don't know how to open "Github security advisory", maybe you could describe the steps.

@oxeye-daniel
Copy link
Author

Hi @Dieken, thanks for the response! We would definitely appreciate your support here since @manolama seems to be quite unresponsive lately. Here is a guide on how to create those advisories, and thanks again :) https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/creating-a-repository-security-advisory

@manolama
Copy link
Member

@oxeye-daniel Sorry for the wait, got it up at GHSA-76f7-9v52-v2fw. Do you have Gal's Github handle to link to? Thanks.

@oxeye-daniel
Copy link
Author

oxeye-daniel commented Jun 14, 2023 via email

@manolama
Copy link
Member

Done, feel free to edit please.

@oxeye-daniel
Copy link
Author

Thanks a lot! We have edited the relevant information. Could you request a CVE now? Thanks

@manolama
Copy link
Member

Done, thanks.

@oxeye-daniel
Copy link
Author

The GitHub security team has requested changes to the advisory on how it differed from a previous CVE. I edited the page, @manolama may I ask you to re-request a CVE?

@oxeye-daniel
Copy link
Author

@manolama
Copy link
Member

GHSA-76f7-9v52-v2fw published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants