-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables linting for typescript, a few bug fixes #653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orconfig + prettier
arntsonl
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fixes! That's a lot of catches, nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tons of fixes for type/lint errors
I will do a separate PR with fixes that could affect functionality , this PR should be mostly formating and removing of unused code.
A few bugs became apparent when going through the lint errors
Fixed:
Not fixed in this PR:
Removes around 120 errors, but still a few left. One step at a time :)
![Skärmavbild 2023-12-07 kl 18 48 54](https://private-user-images.githubusercontent.com/5345892/288848432-651c689e-872e-4b9b-aa09-428c5a54e296.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDg2ODcsIm5iZiI6MTczOTQ0ODM4NywicGF0aCI6Ii81MzQ1ODkyLzI4ODg0ODQzMi02NTFjNjg5ZS04NzJlLTRiOWItYWEwOS00MjhjNWE1NGUyOTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMTIwNjI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWY4MzkwNjBkMTA1NGUyMWQ3MTNhNGE4M2IyYjA2ODZiYmI2MjQ3NTg1ZjI2NDYwMjcxNWQxY2Y3YTQ0NGMwNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.MK67vPB9N1yJj4UM514SSri6o16J0uvhlkV-928bWfo)