JavaScript implementation of makefsdata #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pelsin
reviewed
Nov 20, 2023
Pelsin
reviewed
Nov 20, 2023
Pelsin
reviewed
Nov 21, 2023
|
Tested, seems to work nicely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reimplemented the
makefsdatatool in pure JavaScript. This frees us from having to maintain the binarymakefsdatatool for different platforms, which was always a hassle. Also, the project can now be built on platforms for which we did not previously provide amakefsdatabinary.For compression, I used the pako library, which is a port of the zlib library to JavaScript. The compression is reasonably fast, and it even compresses a bit better than the miniz library we used with the C implementation.
This version of
makefsdatadoes not have all the features of the original, but it covers everything needed for this project.