Make extra keys usable in keyboard mode #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmaccrimm could you pull in latest and increment your config.proto enums based on @mikepparks 's changes? Thank you! |
Sure, done! |
|
Thank you! Re-running the build on this and I'll get it merged. |
arntsonl
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the 12 Extra keys added by #1061 usable in keyboard mode. I found that currently you can map these buttons to keyboard keys in the web config but they won't actually save.
My specific reason for doing this was to re-map the extra up button on my Mavercade controller to a unique training mode shortcut in Street Fighter 6.