Update context sentences in system test #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6db1961
into
Fix/conference_registering
44 of 45 checks passed
Stef-Rousset
added a commit
that referenced
this pull request
May 21, 2024
…#12706) * test:update conference registration system test * test: add registration_types controller test * fix: conference registration_types controller index * correction after PR review * fix: hide register button in conference when no registration types (#1221) * fix: hide register button in conference when no registration types * lint: add missing space in conference show view page * fix: add has_published_registration_types? method to conference model * fix: add rspec for has_published_registration_types? method * lint: fix with rubocop * refacto * fix: update views and system tests after change request * fix: update system spec after review * style: update context sentences in system test (#1223) --------- Co-authored-by: stephanie rousset <strabon@club-internet.fr> Co-authored-by: stephanierousset <61418966+Stef-Rousset@users.noreply.github.com> Co-authored-by: Quentin Champenois <26109239+Quentinchampenois@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix conferences registers when the registration types are empty and registration is enabled
📌 Related Issues
Link your PR to an issue
Related to #?
Fixes Conference registering is broken when no registration_types decidim#12704
Testing
go to admin dashboard
create a conference with registrations enabled and without registration_types
publish the conference
click on See conference button
click on Register button
can access to the registration page
📷 Screenshots
Please add screenshots of the changes you are proposing
Description
co-writter: @BarbaraOliveira13