[Fix] - Marker position on geocoded PP #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliegaboriau
approved these changes
Aug 3, 2022
Quentinchampenois
added a commit
that referenced
this pull request
Aug 9, 2022
* fix tests * Fix map * Clear comments and add previously removed condition * Bump to v2.0.0 * WIP fix CI * fix tests 2.0.0 * lint * include methods * add rake task to install dependencies * linter * rename folder * update readme * Fix/interactive map 0.26 (#36) * Add webpacker installation task * Remove previous task and update README * Rewrite popin HTML templating * Fix scss loading * Add missing decidim map css * Fix rubocop offenses * Fix - Homepage Interactive Map - Participatory Process Marker (#37) * Modifying calculation to fix the bug of the circle going straight out of her participatory_process on interactive map * Trying to fix entirely the bug of the position of the processMarkers * Trying to fix with a further investigation the map but doesn't work yet * Fixing the movement of the participatory process marker * Reverting useless changes * [Fix] - Marker position on geocoded PP (#38) * Add geocoding address to PP in seeds * Updatee process marker position Co-authored-by: eliegaboriau <elie@opensourcepolitics.eu> Co-authored-by: Guillaume MORET <90462045+AyakorK@users.noreply.github.com>
armandfardeau
added a commit
that referenced
this pull request
Apr 18, 2023
* Update Github Actions * Bump dependencies to 0.25.2 * Move to Webpacker and update views * Update participatory_processes form * Fix tests * Add need in wf * Bundle install * Fix offenses * WIP fix js errors * fix tests * Fix map * Clear comments and add previously removed condition * Bump to v2.0.0 * WIP fix CI * fix tests 2.0.0 * lint * include methods * add rake task to install dependencies * linter * rename folder * update readme * Fix/interactive map 0.26 (#36) * Add webpacker installation task * Remove previous task and update README * Rewrite popin HTML templating * Fix scss loading * Add missing decidim map css * Fix rubocop offenses * Fix - Homepage Interactive Map - Participatory Process Marker (#37) * Modifying calculation to fix the bug of the circle going straight out of her participatory_process on interactive map * Trying to fix entirely the bug of the position of the processMarkers * Trying to fix with a further investigation the map but doesn't work yet * Fixing the movement of the participatory process marker * Reverting useless changes * [Fix] - Marker position on geocoded PP (#38) * Add geocoding address to PP in seeds * Updatee process marker position * disable zoom on scrolling * [Fix] - Place PP by address if defined (#42) * Chores/fix map (#43) * Fix dependencies * Remove useless method * Fist version * improve lib and repair existing data * Change destination format * Fix readme * Fix tests * Add more tests * Add convert to commands * Remove unused js * Add dep to module * Fix offenses * Install proj * Add debugger * Add dep * Add new config * Pristine dep * Clean workflow * Update config * Remove unused test * Update apt cache * Pin dep * Add dep * Add readme * Setup cache action * Update readme * Debug * Setup concurrency level * reconstruct shared object cache after build * Add custom matcher * remove debug * Remove useless file * Add debug * Recompile with cache * Use env var * Fix missing require * Symbolize keys * Complete readme * update gemfile * bump 0.27 (#44) * bump 0.27 * update gemfile * fix sass problem * fix CI temporarily * fix CI temporarily * remove sass locking * Update README.md --------- Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com> * Removes need * Set default epsg to WGS 84 (#52) * Set default epsg to WGS 84 * Add arm platform * Fix js dep (#53) --------- Co-authored-by: quentinchampenois <26109239+Quentinchampenois@users.noreply.github.com> Co-authored-by: eliegaboriau <elie@opensourcepolitics.eu> Co-authored-by: Guillaume MORET <90462045+AyakorK@users.noreply.github.com> Co-authored-by: Pauline Bessoles <52420208+paulinebessoles@users.noreply.github.com> Co-authored-by: eliegaboriau <93646702+eliegaboriau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a PP is geocoded, marker takes the position of the PP rather than being placed on the top right corner of the PP marker.
PR's behaviour
Now markers on geocoded PP are placed on the top right corner